Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

garar
Copy link
Contributor

@garar garar commented Aug 5, 2025

Reference Issues/PRs

Fixes #8659

What does this implement/fix? Explain your changes.

This change fixes a problem, which occurred when you've provided CNTC with callbacks arguments.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Should I add a test? If so where? There doesn't seem to be any tests for cntc.py.

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 5, 2025

Thanks! I updated the test configuration so the tests run - they were currently skipped, but now I moved them to a separate VM.

@fkiraly fkiraly added module:classification classification module: time series classification bugfix Fixes a known bug or removes unintended behavior labels Aug 5, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Aug 6, 2025

Should I add a test? If so where? There doesn't seem to be any tests for cntc.py.

You can add test configurations in the get_test_params method - I have pushed it to the pull request.
This will then automatically be used to construct instances in a check_estimator run - this test runs on the VM.

@garar
Copy link
Contributor Author

garar commented Aug 6, 2025

Hi @fkiraly !

Thank you for update test_get_params. Do you need anything else from me right now, or should I wait for core review?

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 6, 2025

I think you should add another example to get_test_params where a callback is used, currently none of the test cases uses callbacks.

@garar garar force-pushed the garar/fix-cntc-callbacks branch from 88c9081 to 23bacdc Compare August 6, 2025 17:24
@garar
Copy link
Contributor Author

garar commented Aug 6, 2025

Hi @fkiraly !

I've added new test case for callbacks, let me know if you need anything else.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thanks - looks great!

(I added a conditional to isolate the soft dependency in get_test_params)

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 6, 2025

failures are unrelated

@fkiraly fkiraly merged commit fb339b4 into sktime:main Aug 6, 2025
93 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CNTCClassifier throws error when you provide callbacks.
2 participants