Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve firewall cancel command #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
allmightyspiff opened this issue Oct 13, 2022 · 1 comment · Fixed by #1822
Closed

Improve firewall cancel command #1768

allmightyspiff opened this issue Oct 13, 2022 · 1 comment · Fixed by #1822
Assignees
@allmightyspiff @caberos
Labels
Bug

Comments

@allmightyspiff
Copy link
Member

I can't seem to cancel this multiVlan firewall. I should be able to cancel it. The help message should also show the available types of firewalls. Also add that information to the detail command

$ slcli firewall cancel multiVlan:17438
This action will cancel a firewall from your account. Continue? [y/N]: y
Unknown firewall type: multiVlan

$ slcli firewall cancel 17438
Invalid ID 17438: ID should be of the form xxx:yyy

$ slcli firewall cancel --help
Usage: slcli firewall cancel [OPTIONS] IDENTIFIER

        Cancels a firewall.

┌────┬────────────┬─────────────────────────────┐
│    │ identifier │                             │
│ -h │ --help     │ Show this message and exit. │
└────┴────────────┴─────────────────────────────┘


$ slcli firewall list
             Single Server Firewalls
┌─────────────┬──────┬──────────┬────────────────┐
│ firewall id │ type │ features │ server/vlan id │
├─────────────┼──────┼──────────┼────────────────┤
└─────────────┴──────┴──────────┴────────────────┘
                                                                     Multi Vlan Firewall
┌───────┬─────────────────────┬───────────────────────────────────┬───────────────────┬──────────┬────────────────┬──────────────┬─────────────────┬────────┐
│  Id   │      firewall       │               type                │     Hostname      │ Location │   Public Ip    │  Private Ip  │ Associated vlan │ status │
├───────┼─────────────────────┼───────────────────────────────────┼───────────────────┼──────────┼────────────────┼──────────────┼─────────────────┼────────┤
│ 17438 │ testFirewall-cgallo │ fortigate-security-appliance-10gb │ dft03.pod03.dal13 │  dal13   │ 67.228.206.245 │ 10.37.115.70 │        0        │ ACTIVE │
└───────┴─────────────────────┴───────────────────────────────────┴───────────────────┴──────────┴────────────────┴──────────────┴─────────────────┴────────┘
@caberos caberos mentioned this issue Nov 2, 2022
Closed
@caberos caberos self-assigned this Nov 3, 2022
@allmightyspiff allmightyspiff linked a pull request Nov 10, 2022 that will close this issue
Improve firewall cancel command #1787
Closed
@allmightyspiff
Copy link
Member Author

TODO

  • Refactor this cancel command to we don't have to specify 'multiVlan', which might be done as part of Firewall refactor identifiers #1820
  • Once we have the ID, we should be able to cancel it by looking up the billing item and putting in a cancellation for that.

@allmightyspiff allmightyspiff removed this from Q4 2022 Jan 10, 2023
@allmightyspiff allmightyspiff moved this to 🏗 In progress in Q1 2023 Jan 10, 2023
@allmightyspiff allmightyspiff self-assigned this Jan 10, 2023
allmightyspiff added a commit to allmightyspiff/softlayer-python that referenced this issue Jan 10, 2023
@allmightyspiff
softlayer#1768 added support for click.Choices in the help text
8d9037e
allmightyspiff added a commit to allmightyspiff/softlayer-python that referenced this issue Jan 10, 2023
@allmightyspiff
softlayer#1768 improved the flow of firewall cancel and it should be …
ad26784 
…able to do multiVlan and single server firewall cancels now
@allmightyspiff allmightyspiff mentioned this issue Jan 10, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Q1 2023 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allmightyspiff allmightyspiff

@caberos caberos

Labels
Bug
Projects
No open projects
Q1 2023
Status: ✅ Done
Milestone
No milestone
2 participants
@allmightyspiff @caberos