Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve firewall cancel command #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve firewall cancel command #1787

wants to merge 1 commit into from

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Nov 2, 2022

@edsonarios
Copy link
Contributor

There is still problems
image

@allmightyspiff allmightyspiff linked an issue Nov 10, 2022 that may be closed by this pull request
Improve firewall cancel command #1768
Closed
allmightyspiff
allmightyspiff requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now there is no way to actually cancel a multiVlan firewall with this command. We either need to improve this command to allow that, or maybe make a new command if that makes sense.

@allmightyspiff
Copy link
Member

Lets revisit this topic once we refactor the firewall identifier stuff (#1820 ). basically I don't want to deal with having users specify multiVlan or singleServer when interacting with firewalls. I think once we get the Searching features in, we can revisit this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff requested changes

@edsonarios edsonarios Awaiting requested review from edsonarios

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
Bug CLI
Projects
No open projects
Q4 2022
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve firewall cancel command
3 participants
@caberos @edsonarios @allmightyspiff