-
Notifications
You must be signed in to change notification settings - Fork 36
feat: implement model switching between deepseek and gpt [SPRW-543] #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
package.json
Outdated
@@ -93,7 +93,10 @@ | |||
"socket.io": "^4.7.5", | |||
"socket.io-client": "^4.8.1", | |||
"uuid": "^9.0.1", | |||
"ws": "^8.18.0" | |||
"ws": "^8.18.0", | |||
"@azure-rest/ai-inference": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not use latest, try to use a version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -93,7 +93,10 @@ | |||
"socket.io": "^4.7.5", | |||
"socket.io-client": "^4.8.1", | |||
"uuid": "^9.0.1", | |||
"ws": "^8.18.0" | |||
"ws": "^8.18.0", | |||
"@azure-rest/ai-inference": "1.0.0-beta.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using the bets version? is their any stable version available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stable version is not provided. On beta version is there in the documentation
@@ -99,6 +118,14 @@ export class AiAssistantService { | |||
return gptAssistantsClient; | |||
}; | |||
|
|||
private getDeepSeekClient = (): ReturnType<typeof ModelClient> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add jsdoc comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prayas17 can you please add proper comments for each steps.
Description
Implemented model switching between deepseek and gpt.
Add Issue Number
Fixes https://techdome.atlassian.net/browse/SPRW-543
Add Screenshots/GIFs
If applicable, add relevant screenshot/gif here.
Add Known Issue
If applicable, add any known issues.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.