Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement model switching between deepseek and gpt [SPRW-543] #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

prayas17
Copy link
Contributor

@prayas17 prayas17 commented May 7, 2025

Description

Implemented model switching between deepseek and gpt.

Add Issue Number

Fixes https://techdome.atlassian.net/browse/SPRW-543

Add Screenshots/GIFs

If applicable, add relevant screenshot/gif here.

Add Known Issue

If applicable, add any known issues.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • I have linked an issue to the pull request.
  • I have linked a PR type label to the pull request.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

package.json Outdated
@@ -93,7 +93,10 @@
"socket.io": "^4.7.5",
"socket.io-client": "^4.8.1",
"uuid": "^9.0.1",
"ws": "^8.18.0"
"ws": "^8.18.0",
"@azure-rest/ai-inference": "latest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not use latest, try to use a version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@prayas17 prayas17 requested a review from LordNayan May 7, 2025 10:05
@@ -93,7 +93,10 @@
"socket.io": "^4.7.5",
"socket.io-client": "^4.8.1",
"uuid": "^9.0.1",
"ws": "^8.18.0"
"ws": "^8.18.0",
"@azure-rest/ai-inference": "1.0.0-beta.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using the bets version? is their any stable version available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable version is not provided. On beta version is there in the documentation

@prayas17 prayas17 requested a review from Astitva877 May 7, 2025 15:17
@prayas17 prayas17 changed the title feat: implement model switching between deepseek and gpt feat: implement model switching between deepseek and gpt [SPRW-543] May 8, 2025
@@ -99,6 +118,14 @@ export class AiAssistantService {
return gptAssistantsClient;
};

private getDeepSeekClient = (): ReturnType<typeof ModelClient> => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add jsdoc comment

Copy link
Member

@Astitva877 Astitva877 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prayas17 can you please add proper comments for each steps.

@prayas17 prayas17 requested a review from Astitva877 May 9, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants