You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I couldn't figure out why I couldn't get my square-figure output to be size 250x250, then I looked at the actual thumbnail image, and it looked like this (ignore the improperly captured static image, this is a Mayavi problem that I need to track down), which I have put in a quoted bit of text so you can see the offset:
This gets created from this original image, which has no such offset:
In other words, SG adds white pillars on either side of the otherwise square image. It seems like this shouldn't be necessary and that CSS should be able to take care of whatever purpose this would serve (e.g., centering the element) instead. Can the rescaling routines be changed to fix this?
The text was updated successfully, but these errors were encountered:
... alternatively, we could expose a thumbnail_size parameter, since the current code will force all real thumbnail images to be 400x280 here and uses pillar / letterboxing to fill any gaps.
I'm also not sure why the "failing example" ones get set to a different size. I guess both sizes are bigger than the default that CSS forces them to be, but I don't see much point in them being different.
larsoner
changed the title
BUG pillarboxes are added to square images when scaling thumbnails
BUG: pillarboxes are added to square images when scaling thumbnails
Aug 2, 2017
Just setting the thumbnail size (tuple) would be sufficient here. And in
the docs say the image is scaled, respecting aspect ratio, to this size,
which might necessitate adding pillar or letterboxing.
I couldn't figure out why I couldn't get my square-figure output to be size 250x250, then I looked at the actual thumbnail image, and it looked like this (ignore the improperly captured static image, this is a Mayavi problem that I need to track down), which I have put in a quoted bit of text so you can see the offset:
This gets created from this original image, which has no such offset:
In other words, SG adds white pillars on either side of the otherwise square image. It seems like this shouldn't be necessary and that CSS should be able to take care of whatever purpose this would serve (e.g., centering the element) instead. Can the rescaling routines be changed to fix this?
The text was updated successfully, but these errors were encountered: