Use module-specific logger in library code instead of root logger #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47587c1 to
91dcc30
Compare
|
+1 on this, using this module is adding a stream handler to my root level logger, which subsequently causes all my logging statements in the rest of my application to output multiple lines. |
|
Hi Splunk team, do you have any comments, thoughts or ideas about failing CI? |
|
I definitely need this. The logs from 'binding.py' are unnecessary for me and only serve to clog up my Splunk index. |
|
Thanks! It's #437, for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to comply with Advanced Logging Tutorial:
This pull request is also almost identical to #94 which I'm not sure why was closed.