Complement type annotations for ARRAY #12386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help when adding type annotations to ARRAY next.
|
I was also thinking about making |
makes sense doing that in a follow up pr |
CaselIT
reviewed
Mar 3, 2025
sqla-tester
reviewed
Mar 5, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c9513ce of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change c9513ce: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5763 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5763 has been merged. Congratulations! :) |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5783 has been merged. Congratulations! :) |
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
This complements the type annotations of the `ARRAY` class, in preparation of #12384. This pull request is: - [ ] A documentation / typographical / small typing error fix - Good to go, no issue or tests are needed - [ ] A short code fix - please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. one line code fixes without tests will not be accepted. - [x] A new feature implementation - please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. Related to #6810 Closes: #12386 Pull-request: #12386 Pull-request-sha: c9513ce Change-Id: If9df4708c8e597eedc79ee3990792fa6c72f1afe (cherry picked from commit 0bf7e02)
dlax
added a commit
to dlax/sqlalchemy
that referenced
this pull request
Mar 18, 2025
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at sqlalchemy#12386 (comment). Related to sqlalchemy#6810.
dlax
added a commit
to dlax/sqlalchemy
that referenced
this pull request
Mar 18, 2025
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at sqlalchemy#12386 (comment). Related to sqlalchemy#6810.
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at #12386 (comment). Related to #6810. Closes: #12443 Pull-request: #12443 Pull-request-sha: 2fff4e8 Change-Id: I87b828fd82d10fbf157141db3c31f0ec8149caad (cherry picked from commit 500adfa)
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at #12386 (comment). Related to #6810. Closes: #12443 Pull-request: #12443 Pull-request-sha: 2fff4e8 Change-Id: I87b828fd82d10fbf157141db3c31f0ec8149caad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This complements the type annotations of the
ARRAYclass, in preparation of #12384.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageRelated to #6810