Make ARRAY generic on the item_type #12443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at sqlalchemy#12386 (comment). Related to sqlalchemy#6810.
dc8433b to
2fff4e8
Compare
sqla-tester
reviewed
Mar 18, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 2fff4e8 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 2fff4e8: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5793 |
|
great work, thanks! |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5793 has been merged. Congratulations! :) |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5794 has been merged. Congratulations! :) |
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Now `Column(type_=ARRAY(Integer)` is inferred as `Column[Sequence[int]]` instead as `Column[Sequence[Any]]` previously. This only works with the `type_` argument to Column, but that's not new. This follows from a suggestion at #12386 (comment). Related to #6810. Closes: #12443 Pull-request: #12443 Pull-request-sha: 2fff4e8 Change-Id: I87b828fd82d10fbf157141db3c31f0ec8149caad (cherry picked from commit 500adfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Column(type_=ARRAY(Integer)is inferred asColumn[Sequence[int]]instead asColumn[Sequence[Any]]previously. This only works with thetype_argument to Column, but that's not new.This follows from a suggestion at
#12386 (comment).
Related to #6810.