Update NativeSqlDatabase.kt to change readonly flag for DELETE, INSERT, and UPDATE statements #5680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df698a6 to
a38aa81
Compare
a38aa81 to
c89ad83
Compare
The implementation of the read-only flag must be set internally - currently it was assumed that sql is either write only or read only. Check sql statements that allow for mutating operations that return results - useReadOnly is set to false The RETURNING clause is only available in top-level DELETE, INSERT, and UPDATE statements
Add driver test cases
4d793e6 to
513ab3c
Compare
AlecKazakova
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5672
The implementation of the read-only flag is set internally and isn't determined by transaction - currently it was assumed that Sql is either write only for mutations or read only for queries that return results