-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix multiple commented out lines not being ignored #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple commented out lines not being ignored #811
Conversation
This was supposed to be fixed by 842aec8, but it wasn't. It now removes all the lines that optionally start with any number of spaces which are followed by 2 consecutive dashes.
I got the commit message wrong, I'm tired. It actually removes anything starting with 2 consecutive dashes up to the end of the line. |
No worries. I'll look at it properly tomorrow. Tired here as well and finishing of some other stuff that doesn't need real thinking about. 😄 |
All that's needed is just to remove everything after |
@innermous, Yes, is there a simpler solution? |
Sec, @revolter , I'll try to figure something out. If I get a better solution, I'll let you know. |
Please wait for me to test this at home with a couple of queries that don't work know before merging. |
Sure. |
Here is a test of the used regex: https://regex101.com/r/O1PB9h/2 |
For reference, the test string set at that url is:
|
This was supposed to be fixed by 842aec8, but it wasn't. It now removes everything that starts with two consecutive dashes, up until the end of the respective line.
This was supposed to be fixed by 842aec8, but it wasn't. It now removes
all the lines that optionally start with any number of spaces which are
followed by 2 consecutive dashes.
Could I get some help with intensive testing?