Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

revolter
Copy link
Member

@revolter revolter commented Oct 8, 2016

This was supposed to be fixed by 842aec8, but it wasn't. It now removes
all the lines that optionally start with any number of spaces which are
followed by 2 consecutive dashes.

Could I get some help with intensive testing?

This was supposed to be fixed by 842aec8, but it wasn't. It now removes
all the lines that optionally start with any number of spaces which are
followed by 2 consecutive dashes.
@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label Oct 8, 2016
@revolter
Copy link
Member Author

revolter commented Oct 8, 2016

I got the commit message wrong, I'm tired. It actually removes anything starting with 2 consecutive dashes up to the end of the line.

@justinclift
Copy link
Member

No worries. I'll look at it properly tomorrow. Tired here as well and finishing of some other stuff that doesn't need real thinking about. 😄

@vtronko
Copy link
Member

vtronko commented Oct 11, 2016

All that's needed is just to remove everything after -- dashes till the end of the lines, am I right?

@revolter
Copy link
Member Author

@innermous, Yes, is there a simpler solution?

@vtronko
Copy link
Member

vtronko commented Oct 11, 2016

Sec, @revolter , I'll try to figure something out. If I get a better solution, I'll let you know.

@revolter
Copy link
Member Author

Please wait for me to test this at home with a couple of queries that don't work know before merging.

@vtronko
Copy link
Member

vtronko commented Oct 11, 2016

Sure.
Don't forget squash commits into one.

@revolter revolter merged commit a4f44d8 into sqlitebrowser:master Oct 11, 2016
@revolter
Copy link
Member Author

Here is a test of the used regex: https://regex101.com/r/O1PB9h/2

@justinclift
Copy link
Member

justinclift commented Oct 11, 2016

For reference, the test string set at that url is:

SELECT * -- asd ffdsf
-- saf ewf sf
-- dsaf fd
FROM    -- sfsdf
table  -- asdasd

vtronko pushed a commit that referenced this pull request Dec 29, 2016
This was supposed to be fixed by 842aec8, but it wasn't. It now removes
everything that starts with two consecutive dashes, up until the end of
the respective line.
@revolter revolter deleted the hotfix/ignore-multiline-comments branch May 30, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants