-
Notifications
You must be signed in to change notification settings - Fork 255
Add a basic schema validation for config files #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic schema validation for config files #978
Conversation
Good for basic validation. More work (and probably some CI automation?) would be needed for correctively validating each of the possible custom checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
===========================================
- Coverage 62.36% 28.66% -33.70%
===========================================
Files 197 209 +12
Lines 4854 5947 +1093
===========================================
- Hits 3027 1705 -1322
- Misses 1439 4126 +2687
+ Partials 388 116 -272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kquinsland
Thanks a lot for your contribution.
Can you please cross-check the properties of the customChecks
array object ?
Co-authored-by: Yann Brillouet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check again the parameters for the customChecks
array items ? I think a description
property is missing there.
Add `customChecks.description`
Good for basic validation.
More work (and probably some CI automation?) would be needed for precisely validating each of the possible custom checks.
This should resolve: #899