Add a basic schema validation for config files #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good for basic validation. More work (and probably some CI automation?) would be needed for correctively validating each of the possible custom checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
===========================================
- Coverage 62.36% 28.66% -33.70%
===========================================
Files 197 209 +12
Lines 4854 5947 +1093
===========================================
- Hits 3027 1705 -1322
- Misses 1439 4126 +2687
+ Partials 388 116 -272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhybrillou
reviewed
Jul 10, 2025
There was a problem hiding this comment.
Hello @kquinsland
Thanks a lot for your contribution.
Can you please cross-check the properties of the customChecks array object ?
Co-authored-by: Yann Brillouet <[email protected]>
rhybrillou
requested changes
Jul 14, 2025
Add `customChecks.description`
rhybrillou
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good for basic validation.
More work (and probably some CI automation?) would be needed for precisely validating each of the possible custom checks.
This should resolve: #899