Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add lapack/base/dlange#10661

Open
dhruvan2006 wants to merge 2 commits intostdlib-js:developfrom
dhruvan2006:dlange
Open

feat: add lapack/base/dlange#10661
dhruvan2006 wants to merge 2 commits intostdlib-js:developfrom
dhruvan2006:dlange

Conversation

@dhruvan2006
Copy link

Resolves #10660

Description

What is the purpose of this pull request?

This pull request:

Changes made:

  • Refactored oneNorm and infinityNorm into a single baseNorm and alternate row/col and strides when calling.
  • Fixed missing abs in absNorm and edited the test suite to catch this in the future
  • Some blocks of code have been refactored to use existing routines in the library (dfill and dmax)

Thanks to @aayush0325 for the heavy lifting.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

dhruvan2006 and others added 2 commits March 2, 2026 22:15
Implement `dlange` to compute the norm of a matrix.

Co-authored-by: Aayush Khanna <[email protected]>
@stdlib-bot stdlib-bot added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Mar 2, 2026
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add lapack/base/dlange

2 participants