Codestin Search App

aayush0325 · 2025-06-03T10:51:31Z

Description

What is the purpose of this pull request?

This pull request:

adds lapack/base/dlange

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-06-03T18:06:15Z

Coverage Report

Package	Statements	Branches	Functions	Lines
lapack/base/dlange	$\color{green}685/685$ $\color{green}+100.00\%$	$\color{red}52/56$ $\color{green}+92.86\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}685/685$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/lapack/base/dlange/README.md

lib/node_modules/@stdlib/lapack/base/dlange/lib/isoperation.js

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

kgryte

Left initial comments.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2025-08-12T07:06:40Z

lib/node_modules/@stdlib/lapack/base/dlange/README.md

+
+# dlange
+
+> LAPACK routine to compute the value of the one norm, or the frobenius norm, or the infinity norm, or the element with the largest absolute value of a real matrix `A`.


Suggested change

> LAPACK routine to compute the value of the one norm, or the frobenius norm, or the infinity norm, or the element with the largest absolute value of a real matrix `A`.

> LAPACK routine to compute the value of the one norm, the frobenius norm, the infinity norm, or the element with the largest absolute value of a real matrix `A`.

Applies here and everywhere else in this PR.

kgryte · 2025-08-12T07:06:56Z

lib/node_modules/@stdlib/lapack/base/dlange/README.md

+
+<section class="intro">
+
+The `dlange` routine computes the value of a specified norm of a real M-by-N matrix `A`. The norm to be computed is selected using the parameter `norm`, which may specify the **Max norm**, **One norm**, **Infinity norm**, or **Frobenius norm**.


Suggested change

The `dlange` routine computes the value of a specified norm of a real M-by-N matrix `A`. The norm to be computed is selected using the parameter `norm`, which may specify the **Max norm**, **One norm**, **Infinity norm**, or **Frobenius norm**.

This routine computes the value of a specified norm of a real M-by-N matrix `A`.

kgryte · 2025-08-12T07:21:12Z

lib/node_modules/@stdlib/lapack/base/dlange/README.md

+The function has the following parameters:
+
+-   **order**: storage layout.
+-   **norm**: specifies the type of norm to be calculated, should be one of the following: `max`, `one`, `frobenius`, or `infinity`.


Suggested change

- **norm**: specifies the type of norm to be calculated, should be one of the following: `max`, `one`, `frobenius`, or `infinity`.

- **norm**: specifies the type of norm to be calculated, should be one of the following: `'max'`, `'one'`, `'frobenius'`, or `'infinity'`.

For string literals, always enclose in single quotes. Otherwise, ambiguous the value type. Here, infinity could mean 'infinity' or the numeric literal infinity. Enclosing in quotes makes this explicit.

kgryte · 2025-08-12T07:21:51Z

lib/node_modules/@stdlib/lapack/base/dlange/README.md

+
+The function has the following additional parameters:
+
+-   **norm**: specifies the type of norm to be calculated, should be one of the following: `max`, `one`, `frobenius`, or `infinity`.


Same comment.

kgryte · 2025-08-12T07:22:55Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+* @param {integer} strideA1 - stride of the first dimension of `A`
+* @param {integer} strideA2 - stride of the second dimension of `A`
+* @param {NonNegativeInteger} offsetA - starting index of `A`
+* @param {Float64Array} work - work array, should have `N` indexed elements if row-major layout is used


Suggested change

* @param {Float64Array} work - work array, should have `N` indexed elements if row-major layout is used

* @param {Float64Array} work - workspace array

kgryte · 2025-08-12T07:23:38Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		for ( i = 0; i < N; i++ ) {
+			work[ iw ] = 0.0;
+			iw += strideWork;
+		}


This can be replaced with a call to blas/ext/base/dfill.

kgryte · 2025-08-12T07:26:30Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		iw = offsetWork;
+		for ( i = 0; i < N; i++ ) {
+			temp = work[ iw ];
+			if ( value < temp || isnan( temp ) ) {
+				value = temp;
+			}
+			iw += strideWork;
+		}


This can be replaced with a call to stats/strided/dmax.

kgryte · 2025-08-12T07:27:08Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		ia1 = offsetA;
+		for ( j = 0; j < N; j++ ) {
+			sum = dasum( M, A, strideA1, ia1 );
+			if ( value < sum || isnan( sum ) ) {


If sum is NaN, we should immediately return, as value will never be less NaN.

kgryte · 2025-08-12T07:28:16Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+	for ( i = 0; i < S1; i++ ) {
+		for ( j = 0; j < S2; j++ ) {
+			temp = A[ ia ];
+			if ( value < temp || isnan( temp ) ) {


Same thing. If temp is NaN, we should immediately return NaN. No need continuing.

kgryte · 2025-08-12T07:29:34Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+
+	for ( i = 0; i < S1; i++ ) {
+		for ( j = 0; j < S2; j++ ) {
+			temp = A[ ia ];


I believe this should be abs( A[ ia ] ). This should have been caught during testing, which means there is a gap in the tests.

kgryte · 2025-08-12T07:31:38Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		ia1 = offsetA;
+		for ( j = 0; j < M; j++ ) {
+			sum = dasum( N, A, strideA2, ia1 );
+			if ( value < sum || isnan( sum ) ) {


Same thing return NaN handling.

kgryte · 2025-08-12T07:31:55Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		for ( i = 0; i < M; i++ ) {
+			work[ iw ] = 0.0;
+			iw += strideWork;
+		}


You can replace with a call to blas/ext/base/dfill.

kgryte · 2025-08-12T07:32:24Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+		iw = offsetWork;
+		for ( i = 0; i < M; i++ ) {
+			temp = work[ iw ];
+			if ( value < temp || isnan( temp ) ) {
+				value = temp;
+			}
+			iw += strideWork;
+		}


You can replace with a call to stats/strided/dmax.

kgryte · 2025-08-12T07:37:58Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+* var out = infinityNorm( 3, 4, A, 4, 1, 0, work, 1, 0 );
+* // returns 30.0
+*/
+function infinityNorm( M, N, A, strideA1, strideA2, offsetA, work, strideWork, offsetWork ) { // eslint-disable-line max-len


Is it me or is the infinityNorm just the oneNorm with A transposed? If so, can we just consolidate implementations into a single function and then have oneNorm and infinityNorm be light wrappers which swap the strides as necessary?

kgryte · 2025-08-12T07:39:18Z

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

+* var out = dlange( 'frobenius', 3, 4, A, 4, 1, 0, work, 1, 0 );
+* // returns ~25.5
+*/
+function dlange( norm, M, N, A, strideA1, strideA2, offsetA, work, strideWork, offsetWork ) { // eslint-disable-line max-len


Rather than disable the lint rule multiple times in this file, just go ahead and disable once above the 'use strict' directive.

aayush0325 added 2 commits June 3, 2025 09:36

stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Jun 3, 2025

aayush0325 marked this pull request as draft June 3, 2025 10:51

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 3, 2025

aayush0325 added Needs Review A pull request which needs code review. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jun 3, 2025

aayush0325 added 17 commits June 3, 2025 18:23

aayush0325 marked this pull request as ready for review June 6, 2025 08:28

kgryte reviewed Jun 7, 2025

View reviewed changes

lib/node_modules/@stdlib/lapack/base/dlange/README.md Outdated Show resolved Hide resolved

kgryte reviewed Jun 7, 2025

View reviewed changes

lib/node_modules/@stdlib/lapack/base/dlange/lib/isoperation.js Show resolved Hide resolved

kgryte reviewed Jun 7, 2025

View reviewed changes

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js Outdated Show resolved Hide resolved

kgryte requested changes Jun 7, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 7, 2025

aayush0325 mentioned this pull request Jun 9, 2025

Weekly Standup (2025-06-09) stdlib-js/google-summer-of-code#157

Closed

aayush0325 added 3 commits June 16, 2025 17:23

aayush0325 requested a review from kgryte June 16, 2025 19:30

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 16, 2025

kgryte mentioned this pull request Jul 11, 2025

feat: add lapack/base/dlange #2704

Closed

4 tasks

kgryte reviewed Aug 12, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Aug 12, 2025

dhruvan2006 mentioned this pull request Mar 2, 2026

feat: add lapack/base/dlange #10661

Open

3 tasks


		# dlange

		> LAPACK routine to compute the value of the one norm, or the frobenius norm, or the infinity norm, or the element with the largest absolute value of a real matrix `A`.


		<section class="intro">

		The `dlange` routine computes the value of a specified norm of a real M-by-N matrix `A`. The norm to be computed is selected using the parameter `norm`, which may specify the Max norm, One norm, Infinity norm, or Frobenius norm.

	The `dlange` routine computes the value of a specified norm of a real M-by-N matrix `A`. The norm to be computed is selected using the parameter `norm`, which may specify the Max norm, One norm, Infinity norm, or Frobenius norm.
	This routine computes the value of a specified norm of a real M-by-N matrix `A`.

	- norm: specifies the type of norm to be calculated, should be one of the following: `max`, `one`, `frobenius`, or `infinity`.
	- norm: specifies the type of norm to be calculated, should be one of the following: `'max'`, `'one'`, `'frobenius'`, or `'infinity'`.


		The function has the following additional parameters:

		- norm: specifies the type of norm to be calculated, should be one of the following: `max`, `one`, `frobenius`, or `infinity`.

	* @param {Float64Array} work - work array, should have `N` indexed elements if row-major layout is used
	* @param {Float64Array} work - workspace array

Uh oh!

Conversation

aayush0325 commented Jun 3, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Jun 3, 2025 •

edited

Loading

kgryte Aug 12, 2025 •

edited

Loading

kgryte Aug 12, 2025 •

edited

Loading