Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

reitermarkus
Copy link
Contributor

Added enums for clock enable and selection registers.

@newAM newAM added the stm32l4 label Apr 17, 2022
@reitermarkus
Copy link
Contributor Author

Some UARTxEN don't exist for some devices, since this applies only to STM32L47xxx, STM32L48xxx, STM32L49xxx and STM32L4Axxx devices. Not sure if there is a way to organize the YAMLs to account for this. Or is it somehow possible to optionally apply a patch, only if the corresponding field exists?

@richardeoin
Copy link
Member

The best way of doing this in the current system is to have a separate yaml file for those uarts that exist only on some families, and then include that from the device yaml in the devices/ folder. For example you would have rcc_l4.yaml included by all parts (as currently) and rcc_l4_uartx_y.yaml included by only some parts

Are the parts you're interested in covered by the part definitions in the devices/ folder? It's possible we don't have all of them yet.

@reitermarkus
Copy link
Contributor Author

Are the parts you're interested in covered by the part definitions in the devices/ folder?

In devices/ there is e.g. stm32l4x6.yaml, this would need e.g. stm32l49x.yaml. Does that work?

@reitermarkus
Copy link
Contributor Author

reitermarkus commented Apr 18, 2022

Or do I need to specifically create e.g. stm32l496.yaml?

@reitermarkus
Copy link
Contributor Author

I had a UART/USART typo before, I think it should be working now after also splitting it up into individual files.

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@reitermarkus
Copy link
Contributor Author

@richardeoin, CI is passing now.

1 similar comment
@reitermarkus
Copy link
Contributor Author

@richardeoin, CI is passing now.

@github-actions
Copy link

Memory map comparison

Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made a few comments inline

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

@reitermarkus
Copy link
Contributor Author

Thanks @richardeoin, I have made the requested changes.

@github-actions
Copy link

Memory map comparison

@github-actions
Copy link

Memory map comparison

Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2022

Build succeeded:

@bors bors bot merged commit 3cbdb48 into stm32-rs:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants