Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ffmpegmux] Fixed bug of an invisible terminal#1502

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
back-to:ffmpegmux
Mar 10, 2018
Merged

[ffmpegmux] Fixed bug of an invisible terminal#1502
gravyboat merged 1 commit into
streamlink:masterfrom
back-to:ffmpegmux

Conversation

@back-to

@back-to back-to commented Feb 22, 2018

Copy link
Copy Markdown
Collaborator

if a ffmpeg stream gets closed with ctrl + c the terminal will get invisible,
this patch will fix it.

@back-to back-to added the bug label Feb 22, 2018
@codecov

codecov Bot commented Feb 22, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1502 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   31.29%   31.29%           
=======================================
  Files         232      232           
  Lines       12827    12827           
=======================================
  Hits         4014     4014           
  Misses       8813     8813

@beardypig beardypig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@gravyboat

Copy link
Copy Markdown
Member

I'm not sure what's with that Python failure, it's bombed out twice and it seems like it just isn't finishing the run from what I can find on the error code.

@back-to

back-to commented Feb 26, 2018

Copy link
Copy Markdown
Collaborator Author

-1073740940 = Heap Corruption Exception 0xC0000374

might be an appveyor issue or some other windows issue


it crashed here already
https://ci.appveyor.com/project/beardypig/streamlink-4m1xi/build/1.0.1383

but worked again in the next build
https://ci.appveyor.com/project/beardypig/streamlink-4m1xi/build/1.0.1384

a bit random,
not really an error with this pr or #1507

if a ffmpeg stream gets closed with ctrl + c the terminal will get
invisible,
this patch will fix it.
@gravyboat

Copy link
Copy Markdown
Member

@back-to Nice good fix.

@gravyboat gravyboat merged commit f25bf21 into streamlink:master Mar 10, 2018
@back-to back-to deleted the ffmpegmux branch March 10, 2018 21:33
@back-to back-to mentioned this pull request Jun 21, 2020
mkbloke pushed a commit to mkbloke/streamlink that referenced this pull request Aug 18, 2020
[ffmpegmux] Fixed bug of an invisible terminal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants