add rtsp plugin#2995
Conversation
4751f03 to
6444ff6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
- Coverage 52.57% 52.46% -0.12%
==========================================
Files 251 252 +1
Lines 15769 15871 +102
==========================================
+ Hits 8291 8327 +36
- Misses 7478 7544 +66 |
|
there are a lot of the same code as |
| MPEG-DASH [2]_ dash:// | ||
| Real Time Messaging Protocol rtmp:// rtmpe:// rtmps:// rtmpt:// rtmpte:// | ||
| Progressive HTTP, HTTPS, etc httpstream:// [1]_ | ||
| Real-Time Streaming Protocol rtspstream:// |
There was a problem hiding this comment.
just rtsp:// should be enough
|
|
||
|
|
||
| class FFMPEGRTSPPlugin(Plugin): | ||
| _url_re = re.compile(r"rtspstream://(?P<scheme>rtsp://)?(?P<url>.+)") |
There was a problem hiding this comment.
just rtsp:// should be enough
|
|
||
| class FFMPEGRTSPPlugin(Plugin): | ||
| _url_re = re.compile(r"rtspstream://(?P<scheme>rtsp://)?(?P<url>.+)") | ||
| _url_schema = validate.Schema( |
There was a problem hiding this comment.
not needed if you just use rtsp://
| t.daemon = True | ||
| t.start() | ||
|
|
||
| self.process = subprocess.Popen(self._cmd, stdout=subprocess.PIPE, |
- Adapted FFMPEGMuxer for muxed / non-muxed streams
|
@back-to Any other input here? If not I want to close this unless it's ready to merge. |
|
I don't like the |
|
I don't like that either, which is why I had previously outsourced it to a separate class so that it could possibly be used for other things and would be more flexible. |
Uses ffmpeg for streaming.