build: add decompress extras marker#6451
Merged
Merged
Conversation
Instead of defining brotli and zstandard directly, rely on urllib3's version requirements and use its brotli and zstd extras markers. brotli or zstandard may be required by some websites which ignore the HTTP client's decompression capabilities set in the Accept-Encoding HTTP header. Both dependencies are picked up automatically if available.
Member
Author
|
Before I'm going to merge this, keep the "decompress" name, or rename to something else? |
gravyboat
approved these changes
Feb 28, 2025
gravyboat
left a comment
Member
There was a problem hiding this comment.
Before I'm going to merge this, keep the "decompress" name, or rename to something else?
I'm fine with decompress. I can't think of a better word that easily explains what is happening based on your notes here and in #6452. If it becomes a problem we can always rename, no reason to over complicate it now though.
pbsds
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jul 11, 2025
This extra was added in Streamlink 7.2.0 and may be required by some websites. See streamlink/streamlink#6451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of defining brotli and zstandard directly, rely on urllib3's version requirements and use its brotli and zstd extras markers.
brotli or zstandard may be required by some websites which ignore the HTTP client's decompression capabilities set in the Accept-Encoding HTTP header. Both dependencies are picked up automatically if available.
https://github.com/urllib3/urllib3/blob/2.3.0/pyproject.toml#L41-L48