plugins.euronews: rewrite and fix plugin#6452
Merged
Merged
Conversation
gravyboat
approved these changes
Feb 28, 2025
gravyboat
left a comment
Member
There was a problem hiding this comment.
Looks good and notes about the reqs are clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6450
If there are any issues with embedded YouTube streams on euronews, like required logins, then there's nothing that can be done. These streams should be freely available and Google simply might block users of certain IP address ranges which they deem bots or otherwise untrustworthy.
brotliis required when trying to access certain parts of euronews.com. Their websevers simply ignore theAccept-Encodingheader, and the response is always compressed using brotli.I've therefore added the
decompressextras marker in #6451, so Streamlink can properly annotate these optional transitive dependencies. I've already manually included brotli in the Windows builds and Linux AppImages for a long time.