Popover with help and use_container_width is rendered correctly #10709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
reviewed
Mar 10, 2025
mayagbarnes
approved these changes
Mar 10, 2025
sfc-gh-bnisco
approved these changes
Mar 10, 2025
| <BaseButtonTooltip help={element.help}> | ||
| <BaseButtonTooltip | ||
| help={element.help} | ||
| containerWidth={element.useContainerWidth} |
Collaborator
There was a problem hiding this comment.
suggestion (non-blocking): I think it could be a good idea to mark containerWidth as a required prop in BaseButtonTooltip. The benefit is that we would get compiler-time checking for all locations in which BaseButtonTooltip is used.
Collaborator
There was a problem hiding this comment.
Added in st.page_link PR 👍🏼 - just need this PR merged before I can merge
Collaborator
Author
There was a problem hiding this comment.
Great, thank you Maya for adding this.
kajarenc
pushed a commit
that referenced
this pull request
Mar 11, 2025
## Describe your changes This fixes an issue where `use_container_width` is ignored if the `help` parameter is passed to `st.popover` by ensuring `element.useContainerWidth` is provided to `BaseButtonTooltip` as well as `BaseButton`. ## GitHub Issue Link (if applicable) Closes #10693 ## Testing Plan Adds some playwright tests similar to the existing `use_container_width` tests but including the help option. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This fixes an issue where
use_container_widthis ignored if thehelpparameter is passed tost.popoverby ensuringelement.useContainerWidthis provided toBaseButtonTooltipas well asBaseButton.GitHub Issue Link (if applicable)
Closes #10693
Testing Plan
Adds some playwright tests similar to the existing
use_container_widthtests but including the help option.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.