Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bagedevimo
Copy link

Summary & motivation

  • Upgrade React and associated packages & types to React 19.x
  • Convert React imports to use the recommended import syntax

Testing & documentation

I compared the output of dist/ on master vs this branch and checked each change was the expected change.

Doing so prevents any named imports leaking into the output type
definitions (.d.ts files) and follows with what seems to be the React
official recommendations [1].

The more 'correct' fix would be only import those components that are
needed by each component, but that's a bigger change.

[1] facebook/react#18102

Fixes stripe#569
Copy link

cla-assistant bot commented Apr 12, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Apr 12, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

stale bot commented May 2, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 2, 2025
@bagedevimo
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This is definitely not stale. Stripe team, maybe add a tag or something to issues / MRs you have replied too so this stops happening?

@stale stale bot removed the stale label May 2, 2025
Copy link

stale bot commented May 23, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 23, 2025
@bagedevimo
Copy link
Author

This is still not stale stale-bot.

@stale stale bot removed the stale label May 23, 2025
Copy link

stale bot commented Jun 14, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 14, 2025
@bagedevimo
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

No thank you

@stale stale bot removed the stale label Jun 14, 2025
@boutterudy
Copy link

Thanks for the PR @bagedevimo! πŸ™

It's definitely important to make this update, hopefully the Stripe team merge your PR soon πŸ‘€

@ruisilva450
Copy link

Won't this prevent any project that's still using react 18 from using this version?

@bagedevimo
Copy link
Author

Won't this prevent any project that's still using react 18 from using this version?

No, the minimum sdk constraint is unchanged - this is just bumping the version of react this libraries types are generated using. Note that the before this PR, people could use this library (current version React 18) all the way down to React 16, which is the current minimum SDK constraint.

@jake-brandt
Copy link

Created a second PR based off of this work; but rebased on what was the latest in master as of an hour or so ago. I've been dealing with React 19 upgrade "fun" on another project today (Stripe's React library being one of our dependencies), so I'm hoping this helps get @bagedevimo 's contributions over the finish line. I may head back to CGI scripts if I have to deal with any more framework upgrades πŸ™ƒ

See #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants