-
Notifications
You must be signed in to change notification settings - Fork 300
Upgrade to React 19 #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade to React 19 #585
Conversation
Doing so prevents any named imports leaking into the output type definitions (.d.ts files) and follows with what seems to be the React official recommendations [1]. The more 'correct' fix would be only import those components that are needed by each component, but that's a bigger change. [1] facebook/react#18102 Fixes stripe#569
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is definitely not stale. Stripe team, maybe add a tag or something to issues / MRs you have replied too so this stops happening? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still not stale stale-bot. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
No thank you |
Thanks for the PR @bagedevimo! π It's definitely important to make this update, hopefully the Stripe team merge your PR soon π |
Won't this prevent any project that's still using react 18 from using this version? |
No, the minimum sdk constraint is unchanged - this is just bumping the version of react this libraries types are generated using. Note that the before this PR, people could use this library (current version React 18) all the way down to React 16, which is the current minimum SDK constraint. |
Created a second PR based off of this work; but rebased on what was the latest in See #623 |
Summary & motivation
Testing & documentation
I compared the output of dist/ on master vs this branch and checked each change was the expected change.