Refactor PR template based on feedback #2865
Conversation
|
@raymondfeng @ritch Please provide your feedback (the ones from sprint demo). |
|
|
||
| - [ ] SEMVER-MAJOR -- Backwards-incompatible changes | ||
| - [ ] SEMVER-MINOR -- Add functionality in a backwards-compatible manner | ||
| - [ ] SEMVER-PATCH -- Backwards-compatible bug fixes |
There was a problem hiding this comment.
@bajtos There was a proposal during demo to remove this as we should be the ones determining this to (instead of putting the burden on community -- we determine what are patches, backwards compatible etc). Also remove extra barriers for contributors and I agree (contrary to the initial proposal) -- as did @eddiemonge @raymondfeng @ritch during demo.
| - [ ] Code conforms with the [style | ||
| guide](http://loopback.io/doc/en/contrib/style-guide.html) | ||
| - [ ] All CI builds are passing (semi-required, left up to discretion of the | ||
| reviewer) |
There was a problem hiding this comment.
@bajtos @raymondfeng @ritch I'm proposing we remove the commit message, new tests added and code passes npm test items as "All CI builds are passing" already checks these 3 items for us. If CI fails, one of those 3 items failed anyways. Thoughts? ie. reduce to:
- [ ] CLA signed
- [ ] Code conforms with the [style
guide](http://loopback.io/doc/en/contrib/style-guide.html)
- [ ] All CI Builds are passing
The style guide requirements are subjective but might be worth leaving in since we'll be asking them to check each time we review anyways.
| - [ ] Commit message conforms with the [Git commit message | ||
| guidelines](http://loopback.io/doc/en/contrib/git-commit-messages.html) | ||
| - [ ] New tests are added to cover all changes | ||
| - [ ] Code passes `npm test` |
There was a problem hiding this comment.
@bajtos @raymondfeng @ritch I'm proposing we remove the commit message, new tests added and code passes npm test items as "All CI builds are passing" already checks these 3 items for us. If CI fails, one of those 3 items failed anyways. Thoughts? ie. reduce to:
- [ ] CLA signed
- [ ] Code conforms with the [style
guide](http://loopback.io/doc/en/contrib/style-guide.html)
- [ ] All CI Builds are passing
The style guide requirements are subjective but might be worth leaving in since we'll be asking them to check each time we review anyways.
There was a problem hiding this comment.
A second note regarding the above is this is better for the longer term too. IMO, we do not need more bullet point items, we need to open up CI to allow community to check themselves -- the CI will tell them their commit message does not conform, etc. Just like how it tells us internally.
bajtos
left a comment
There was a problem hiding this comment.
I strongly object against removing "New tests are added to cover all changes". I don't have numbers, but in my experience most of pull requests don't have necessary test coverage. I want the pull request template to make it clear that we are expecting contributors to include tests.
As for the rest of the changes, I don't care much and I am happy to go with the opinion of majority.
867e758 to
c7e35ef
Compare
Updated based on feedback received during sprint demo.
c7e35ef to
ae9be8c
Compare
Updated based on feedback received during sprint demo. Backport of #2865
| guide](http://loopback.io/doc/en/contrib/style-guide.html) | ||
| - [ ] All CI builds are passing (semi-required, left up to discretion of the | ||
| reviewer) | ||
| - [ ] All CI builds are passing |
There was a problem hiding this comment.
this one is kind of moot since github will tell us this in the PR itself.
|
|
||
| ### Checklist | ||
|
|
||
| - [ ] CLA signed |
There was a problem hiding this comment.
I didn't realize there was a bot for this one. So:
this one is kind of moot since github will tell us this in the PR itself.
There was a problem hiding this comment.
True, the bot will do it. Removing. 👍
* Need index on principalId for performance. (#2883) (#2884) (Simon Ho) * Remove redundant items in PR template (#2877) (#2878) (Simon Ho) * Refactor PR template based on feedback (#2865) (#2874) (Simon Ho) * Add pull request template (#2843) (#2862) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš)
* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to #49 (#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (#2883) (Simon Ho) * Remove redundant items in PR template (#2877) (Simon Ho) * Refactor PR template based on feedback (#2865) (Simon Ho) * Add pull request template (#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (#2854) (Simon Ho) * Add how to tick checkbox in issue template (#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)
* Fix use-strict issue with connectors after merge (Loay) * Fix connector naming in strict mode (ebarault) * Add "returnOnlyRoleNames" option to Role.getRoles (Eric) * Update translation files (Candy) * Fix broken document for `upsertWithWhere` (Amir Jafarian) * Fix js doc for deleteAll event (Candy) * add allowArray to relations' create remoteMethod (David Cheung) * Remove workaround for default value (Loay) * Fix remote method example (Amir Jafarian) * Remove `example/context` (Amir Jafarian) * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš) * Update eslint to loopback config v5 (Loay) * Fix total calculation in example (Candy) * make test individually runable (David Cheung) * Add options to bulkUpdate (Kogulan Baskaran) * Fix context within listByPrincipalType role method (codyolsen) * Add Node v7 to Travis CI platforms (Miroslav Bajtoš) * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš) * Add templateFn option to User#verify() (Adrien Kiren) * Require verification after email change (Loay) * Update doc links (Candy) * adding check of string for case insensitive emails (Dhaval Trivedi) * Update test confirmation text in PR template (strongloop#2897) (Simon Ho) * allow batch create for persisted models (David Cheung) * Fix PR template to not link all PRs to strongloop#49 (strongloop#2887) (Miroslav Bajtoš) * Need index on principalId for performance. (strongloop#2883) (Simon Ho) * Remove redundant items in PR template (strongloop#2877) (Simon Ho) * Refactor PR template based on feedback (strongloop#2865) (Simon Ho) * Add pull request template (strongloop#2843) (Simon Ho) * Update README.md (Rand McKinney) * Reword ticking checkbox note in issue template (strongloop#2854) (Simon Ho) * Add how to tick checkbox in issue template (strongloop#2851) (Simon Ho) * Fix description of updateAll response (Miroslav Bajtoš) * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš) * Use GitHub issue templates (strongloop#2810) (Simon Ho) * Update ja and nl translation files (Candy) * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš) * Fix support for remote hooks returning a Promise (Tim van der Staaij) * Validate non-email property partial update (Loay) * Update release notes (Amir Jafarian) * Update translation files - round#2 (Candy) * Add license text (Candy) * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)
Updated based on feedback received during sprint demo.
PTAL @bajtos