Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove redundant items in PR template (#2877) #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
superkhau merged 1 commit into from
Oct 20, 2016
Merged

Remove redundant items in PR template (#2877) #2878

superkhau merged 1 commit into from
Oct 20, 2016

Conversation

@superkhau
Copy link
Contributor

@superkhau superkhau commented Oct 20, 2016

  • Remove sign CLA since CI already shows unsigned CLAs
  • Remove all tests must pass CI since we have to check each on a case by
    case basis anyways
  • Update example to include linking to the current repo using number
    sign (ie. Fix missing assert module #49 in addition to org/repo#49)

Backport of #2877

@superkhau @simonhoibm
Remove redundant items in PR template (#2877)
70b46a1 
- Remove sign CLA since CI already shows unsigned CLAs
- Remove all tests must pass CI since we have to check each on a case by
  case basis anyways
- Update example to include linking to the current repo using number
  sign (ie. #49 in addition to org/repo#49)

Backport of #2877
@superkhau superkhau self-assigned this Oct 20, 2016
@superkhau superkhau merged commit df13b09 into 2.x Oct 20, 2016
@superkhau superkhau deleted the backport/remove-redundant-items-in-pr-template branch October 20, 2016 01:25
@superkhau superkhau removed the #review label Oct 20, 2016
bajtos added a commit that referenced this pull request Oct 24, 2016
@bajtos
2.36.0
4cb9f0d 
 * Need index on principalId for performance. (#2883) (#2884) (Simon Ho)
 * Remove redundant items in PR template (#2877) (#2878) (Simon Ho)
 * Refactor PR template based on feedback (#2865) (#2874) (Simon Ho)
 * Add pull request template (#2843) (#2862) (Simon Ho)
 * Fix description of updateAll response (Miroslav Bajtoš)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@superkhau superkhau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@superkhau