Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix all tests everywhere all at once#8637

Merged
Cadair merged 11 commits into
sunpy:mainfrom
Cadair:gallery_fixes
May 20, 2026
Merged

Fix all tests everywhere all at once#8637
Cadair merged 11 commits into
sunpy:mainfrom
Cadair:gallery_fixes

Conversation

@Cadair
Copy link
Copy Markdown
Member

@Cadair Cadair commented May 18, 2026 •
edited
Loading

Fixes #8564

@Cadair Cadair changed the title Online fixes to gallery and other places Fix all tests everywhere May 18, 2026
@alasdairwilson alasdairwilson changed the title Fix all tests everywhere Fix all tests everywhere all at once May 18, 2026
@Cadair
Copy link
Copy Markdown
Member Author

Cadair commented May 19, 2026

I think this whole thing probably wants backporting as is?

@Cadair Cadair added net Affects the net submodule Examples Related to the Example Gallery. Infrastructure Issues or PRs that affect the CI or packaging. backport 7.0 on-merge: backport to 7.0 backport 7.1 on-merge: backport to 7.1 labels May 19, 2026
@Cadair Cadair added this to the 8.0.0 milestone May 19, 2026
@Cadair Cadair added the Run cron CI Run cron CI on this PR. label May 19, 2026
ayshih
ayshih reviewed May 19, 2026
View reviewed changes
Comment thread sunpy/net/hek/tests/test_hek.py Outdated
@Cadair Cadair force-pushed the gallery_fixes branch 3 times, most recently from 8571265 to 7e20a58 Compare May 20, 2026 15:30
@Cadair Cadair marked this pull request as ready for review May 20, 2026 15:31
@Cadair Cadair requested a review from ayshih May 20, 2026 15:31
@Cadair Cadair added the Needs Review Needs review(s) before merge. label May 20, 2026
alasdairwilson
alasdairwilson approved these changes May 20, 2026
View reviewed changes
Comment thread docs/conf.py Outdated
Comment thread sunpy/net/dataretriever/sources/tests/test_adapt.py
"Physobs": "flux",
"Source": "GONG",
"Provider": "NSO",
"url": ("https://gong.nso.edu/adapt/maps/gong/2024/adapt41311_044012_202409290200_i00013600n1.fts.gz"),
Copy link
Copy Markdown
Member

@alasdairwilson alasdairwilson May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

Comment thread sunpy/net/dataretriever/sources/adapt.py Outdated
ayshih
ayshih approved these changes May 20, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
envs: |
- linux: build_docs
pytest: false
posargs: -D html_theme_options.collapse_navigation=True
Copy link
Copy Markdown
Member

@ayshih ayshih May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested adding a comment that setting this option is specifically for speeding up the CI

Comment thread docs/conf.py
Comment on lines +54 to +55
spiceypy_log = logging.getLogger("spiceypy.utils.libspicehelper")
spiceypy_log.setLevel(logging.ERROR)
Copy link
Copy Markdown
Member

@ayshih ayshih May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What spiceypy logging messages were showing up?

Copy link
Copy Markdown
Member Author

@Cadair Cadair May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One log line about where it was loading the compiled library from.

@Cadair Cadair merged commit ab245ae into sunpy:main May 20, 2026
10 of 13 checks passed
@Cadair Cadair deleted the gallery_fixes branch May 20, 2026 16:28
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 20, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.0
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab245ae2e1b29c98bd69c7fbb95ae60103b2adc2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #8637: Fix all tests everywhere all at once'
  1. Push to a named branch:
git push YOURFORK 7.0:auto-backport-of-pr-8637-on-7.0
  1. Create a PR against branch 7.0, I would have named this PR:

"Backport PR #8637 on branch 7.0 (Fix all tests everywhere all at once)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport This PR needs manually backporting. label May 20, 2026
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 20, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.1
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab245ae2e1b29c98bd69c7fbb95ae60103b2adc2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #8637: Fix all tests everywhere all at once'
  1. Push to a named branch:
git push YOURFORK 7.1:auto-backport-of-pr-8637-on-7.1
  1. Create a PR against branch 7.1, I would have named this PR:

"Backport PR #8637 on branch 7.1 (Fix all tests everywhere all at once)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@Cadair Cadair removed the Still Needs Manual Backport This PR needs manually backporting. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayshih ayshih ayshih approved these changes

@alasdairwilson alasdairwilson alasdairwilson approved these changes

Assignees

No one assigned

Labels

backport 7.0 on-merge: backport to 7.0 backport 7.1 on-merge: backport to 7.1 Examples Related to the Example Gallery. Infrastructure Issues or PRs that affect the CI or packaging. Needs Review Needs review(s) before merge. net Affects the net submodule Run cron CI Run cron CI on this PR.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Cron devdeps build failure

3 participants

@Cadair @ayshih @alasdairwilson