-
-
Notifications
You must be signed in to change notification settings - Fork 660
Fix all tests everywhere all at once #8637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1c2343d
Fix HEK tests
Cadair ff35c7a
Fix deps and pytest marker config
Cadair be9b27a
Fix ADAPT client
Cadair f02c117
Fix gallery issues
Cadair 57df993
Ignore warning in cdflib
Cadair 3b3f670
Refactor SRS reader to avoid setting dtype
Cadair d3841c4
Don't use EUI for solarnet due to outage
Cadair e5eed7a
Only do one online build at once in CI or JSOC races
Cadair 4f16fa6
linkcheck and sphinx output cleanup
Cadair 711ff4d
Save build time on ci by not building full navigation bar
Cadair e1dd91a
Only build sdist on PRs with label
Cadair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Update the ADAPT client for new filename patterns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |
| import datetime | ||
| import warnings | ||
| import tokenize | ||
| import logging | ||
| from pathlib import Path | ||
|
|
||
| from packaging.version import Version | ||
|
|
@@ -39,12 +40,20 @@ | |
| from ruamel.yaml import YAML | ||
| from sphinx_gallery.sorting import ExplicitOrder | ||
| from sunpy_sphinx_theme import PNG_ICON | ||
| from sphinx.util import logging as sphinx_logging | ||
| sphx_logger = sphinx_logging.getLogger(__name__) | ||
|
|
||
| from astropy.utils.exceptions import AstropyDeprecationWarning | ||
| from astropy.io.fits.verify import VerifyWarning | ||
| import sunpy | ||
| from sunpy.util.exceptions import SunpyDeprecationWarning, SunpyPendingDeprecationWarning | ||
|
|
||
| # Hide log output during the sphinx build as it pollutes the output | ||
| # and makes it harder to see real sphinx warnings | ||
| sunpy.log.setLevel(logging.ERROR) | ||
| spiceypy_log = logging.getLogger("spiceypy.utils.libspicehelper") | ||
| spiceypy_log.setLevel(logging.ERROR) | ||
|
Comment on lines
+54
to
+55
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One log line about where it was loading the compiled library from. |
||
|
|
||
| # -- Project information ------------------------------------------------------- | ||
|
|
||
| # The full version, including alpha/beta/rc tags | ||
|
|
@@ -110,7 +119,11 @@ | |
| # This is super slow to check | ||
| r"https://mathesaurus\.sourceforge\.net/idl-numpy\.html", | ||
| # You have to be logged into GitHub in order to project wide issue searches | ||
| r"https://github.com/issues?.*" | ||
| r"https://github.com/issues?.*", | ||
| # They have an incomplete certificate chain which works in browsers but not CLI | ||
| r"https://suit.iucaa.in.*", | ||
| # I have no idea why these URLs 403 for linkcheck but pass every other way I try them | ||
| r"https://docutils.sourceforge.io/.*", | ||
| ] | ||
| linkcheck_anchors = False | ||
| linkcheck_timeout = 120 | ||
|
|
@@ -330,7 +343,7 @@ def linkcode_resolve(domain, info): | |
| source, lineno = inspect.getsourcelines(obj) | ||
| except (OSError, TypeError, tokenize.TokenError): | ||
| if hasattr(obj, '__qualname__'): | ||
| print(f"linkcode_resolve: could not get source for {obj.__module__}.{obj.__qualname__}") | ||
| sphx_logger.info(f"linkcode_resolve: could not get source for {obj.__module__}.{obj.__qualname__}") | ||
| lineno = None | ||
|
|
||
| linespec = (f"#L{lineno:d}-L{lineno + len(source) - 1:d}" | ||
|
|
@@ -451,7 +464,7 @@ def jinja_to_rst(app, docname, source): | |
| jinja_pages = ["reference/stability", "dev_guide/index"] | ||
| if app.builder.format == 'html': | ||
| if docname in jinja_pages: | ||
| print(f"Jinja rendering {docname}") | ||
| sphx_logger.info(f"Jinja rendering {docname}") | ||
| rendered = app.builder.templates.render_string( | ||
| source[0], app.config.html_context | ||
| ) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested adding a comment that setting this option is specifically for speeding up the CI