Joshen/fe 3213 make rls tester feedback callout more obvious#45820
Joshen/fe 3213 make rls tester feedback callout more obvious#45820joshenlim wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new telemetry event type ChangesRLS Tester Telemetry
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/studio/components/interfaces/Auth/RLSTester/RLSTesterSheet.tsx`:
- Line 45: The component currently imports and uses useSendEventMutation (and
likely calls sendEvent with manually set groups) — replace that usage with the
standard Studio telemetry hook useTrack from 'lib/telemetry/track' in
RLSTesterSheet.tsx; remove the direct useSendEventMutation import and any manual
groups construction, call the returned track function (or the hook's API) to
emit the same event name/payload so built-in context/groups are applied
automatically, and only pass explicit group overrides if absolutely required;
update all occurrences referenced (the import at the top and the event calls
where sendEvent/useSendEventMutation is invoked).
In `@packages/common/telemetry-constants.ts`:
- Around line 3448-3450: Rename the telemetry action in the
RLSTesterQueryRanEvent interface from 'rls_tester_query_ran' to an approved verb
form like 'rls_tester_query_submitted', update the interface declaration
(RLSTesterQueryRanEvent) accordingly, and search for and update all
emitters/usages that reference the old action string so they emit the new
'rls_tester_query_submitted' value; ensure any tests or telemetry mapping that
rely on the previous action are updated to the new name to keep interface and
emitters aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: eb7fff46-f55f-4fba-95a4-bfbca0d90db8
📒 Files selected for processing (2)
apps/studio/components/interfaces/Auth/RLSTester/RLSTesterSheet.tsxpackages/common/telemetry-constants.ts
🎭 Playwright Test ResultsDetails
Flaky testsFeatures › database-webhooks.spec.ts › Database Webhooks › preserves webhook URL path and custom headers after editing Skipped testsFeatures › auth-users.spec.ts › should show web3 users as enabled when the matching web3 provider is enabled |
Context
Minor nit to adjust the "Give feedback" button at the bottom to use default type + external link icon

Also added telemetry for the "Run query" button
Summary by CodeRabbit
New Features
Style