-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat(prefer-svelte-reactivity): ignoring encapsulated local variables by default #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(prefer-svelte-reactivity): ignoring encapsulated local variables by default #1287
Conversation
🦋 Changeset detectedLatest commit: fe64eed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
e353727
to
be6878b
Compare
Hey @ota-meshi @baseballyama, sorry to ping you, but could you please help me with the CI? I have no idea why it fails and how to debug it :( |
Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :) |
9354900
to
d853d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
I think this PR contains changes for multiple purposes.
Could you split it into several PRs?
I think at least the following two should be split:
- Add the
ignoreEncapsulatedLocalVariables
option - Tracking private properties
3466ad0
to
433cde8
Compare
Ok, I've started in #1326 but I'm afraid the PRs will have to be (mostly) sequential because otherwise there'll just be too many conflicts. |
433cde8
to
fe64eed
Compare
Fixes #1271