Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Aug 6, 2025

Fixes #1271

Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: fe64eed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@fe64eed

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch 27 times, most recently from e353727 to be6878b Compare August 6, 2025 19:19
@marekdedic marekdedic marked this pull request as ready for review August 6, 2025 19:21
@marekdedic
Copy link
Contributor Author

Hey @ota-meshi @baseballyama, sorry to ping you, but could you please help me with the CI? I have no idea why it fails and how to debug it :(

@marekdedic
Copy link
Contributor Author

Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :)

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch 10 times, most recently from 9354900 to d853d1b Compare August 8, 2025 09:39
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
I think this PR contains changes for multiple purposes.
Could you split it into several PRs?
I think at least the following two should be split:

  • Add the ignoreEncapsulatedLocalVariables option
  • Tracking private properties

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch from 3466ad0 to 433cde8 Compare September 4, 2025 22:22
@marekdedic
Copy link
Contributor Author

Ok, I've started in #1326 but I'm afraid the PRs will have to be (mostly) sequential because otherwise there'll just be too many conflicts.

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch from 433cde8 to fe64eed Compare September 14, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte/prefer-svelte-reactivity triggers inside non-reactive functions (e.g., URL, Date, Set usage)
2 participants