Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: include components dynamically imported in the universal load function when inlining CSS #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 5, 2025
Merged

fix: include components dynamically imported in the universal load function when inlining CSS #13723

merged 7 commits into from
Jun 5, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Apr 17, 2025 •
edited
Loading

fixes #13670

This PR changes how we map client stylesheets to their server equivalent by using the Rollup bundle data from the client and server builds instead of the Vite manifests. This allows us to correctly map stylesheets for components that aren't pages or layouts. This is only possible with the Rollup bundle data because it has the original module IDs where the CSS originated from. In contrast, the current approach maps the stylesheet names to the node index but doesn't work if the component stylesheet has a name other than a node index.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3743896

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino marked this pull request as ready for review April 17, 2025 12:40
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13723-svelte.vercel.app/

@keshavdhawan281
Copy link

What is the release plan for this fix? We still have downgraded version of sveltekit running in our project.

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit 6c44239 into main Jun 5, 2025
18 checks passed
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the fix-stylesheet-inline branch June 5, 2025 17:29
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
@tkhs0813 tkhs0813 mentioned this pull request Jun 11, 2025
Open
@tkhs0813
Copy link
Contributor

@elliott-with-the-longest-name-on-github @eltigerchino
#13878
After updating to sveltekit 2.21.3, I am having issues with some styles not being reflected. I have set inlineStyleThreshold: 100_000 and am not dynamically importing with the universal load function.

Do you know anything?

sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
d10dda9 
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic imported components - Stylesheets not getting inlined
4 participants
@eltigerchino @keshavdhawan281 @tkhs0813 @elliott-with-the-longest-name-on-github