Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: correctly invalidate static analysis cache of child nodes during dev #13793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 5, 2025
Merged

fix: correctly invalidate static analysis cache of child nodes during dev #13793

merged 16 commits into from
Jun 5, 2025
+118 −69

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 15, 2025 •
edited
Loading

Forgot to add the static analysis cache invalidation to the Vite file change listener. Currently, if the page options of a parent node is updated during development, the child nodes incorrectly use the stale cached results instead of inheriting the new page options of the parent.

This PR intends to ensure updating the page options in a layout during development updates the affected children too.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino changed the title fix: avoid caching static analysis results during dev fix: correctly invalidate static analysis cache during dev May 15, 2025
eltigerchino
eltigerchino commented May 15, 2025
View reviewed changes
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 28f1227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

benmccann
benmccann reviewed May 15, 2025
View reviewed changes
@eltigerchino eltigerchino changed the title fix: correctly invalidate static analysis cache during dev fix: correctly invalidate static analysis cache of child nodes during dev May 16, 2025
@eltigerchino eltigerchino marked this pull request as draft May 16, 2025 09:40
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13793-svelte.vercel.app/

@eltigerchino eltigerchino marked this pull request as ready for review May 29, 2025 09:41
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit 6a6538c into main Jun 5, 2025
18 checks passed
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the fix-static-analysis-caching branch June 5, 2025 17:27
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
@jeannemas jeannemas mentioned this pull request Jun 10, 2025
Closed
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
d10dda9 
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eltigerchino @benmccann @elliott-with-the-longest-name-on-github