Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enhancement: Add PHP 7.4 stable build which is not allowed to fail #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Enhancement: Add PHP 7.4 stable build which is not allowed to fail #692

wants to merge 3 commits into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

@weaverryan
Copy link
Member

The problem is the MAKER_TEST_VERSION=dev should be allowed to fail.

So, best would be to make a new matrix item for just PHP 7.4, but then we take more CI resources from the rest of the symfony org.

OskarStark
OskarStark commented Oct 23, 2020
View reviewed changes
@OskarStark OskarStark changed the title Enhancement: Do not allow failures for PHP 7.4 Enhancement: Add PHP 7.4 stable build which is not allowed to fail Oct 23, 2020
@OskarStark
Copy link
Contributor Author

I updated the code and the PR title accordingly 👍

@OskarStark
Copy link
Contributor Author

So, best would be to make a new matrix item for just PHP 7.4, but then we take more CI resources from the rest of the symfony org.

I will tackle this problem in #693

@OskarStark
Copy link
Contributor Author

Superseded by #701

@OskarStark OskarStark closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @weaverryan @jrushlow