Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated "--env" and "--no-debug" console options #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Oct 28, 2018

Q A
License MIT

Continuation of symfony/symfony#28653
Since the recipes are only used for new projects this seems safe to do. We do not want to promote using these options anymore.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Tobion
Copy link
Contributor Author

Tobion commented Oct 28, 2018

Documentation wise https://symfony.com/doc/3.4/console/usage.html still mentions these options for symfony < 4. Maybe we should remove the page for 3.4 as well and add this part instead: https://symfony.com/doc/current/console.html#the-console-app-env-app-debug

@chalasr
Copy link
Member

chalasr commented Oct 28, 2018

@Tobion It's similar to the new directory structure: the old translations/templates locations are still part of the 3.4 docs but the new ones are not, while they are actually supported since 3.4.
I believe we consider APP_ENV a Symfony 4 thing "officially", even if we started experimenting it in 3.4

@ogizanagi
Copy link
Contributor

ogizanagi commented Oct 28, 2018

#466 will contain these changes in a 4.2 recipe. I'd suggest either to wait for it to be (tweaked and) merged, or create the missing 4.2 recipe for console instead.

javiereguiluz added a commit to symfony/demo that referenced this pull request Nov 6, 2018
…bion)

This PR was merged into the master branch.

Discussion
----------

Remove deprecated --env and --no-debug console options

See symfony/recipes#479

Commits
-------

6c49d74 Remove deprecated --env and --no-debug console options
@nicolas-grekas
Copy link
Member

Should we really do this? In symfony/symfony#28984, people are complaining removing these attributes make the console harder to use for them. We did deprecate the options from core - and this was the thing to do to me also. BUT shouldn't we continue to allow using them here?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just locking merges, I'd like my previous comment to be resolved first.)

@ogizanagi
Copy link
Contributor

That's for new projects or people manually upgrading to new versions of these recipes. A new project should be free of deprecations by default, that's my main argument here. No stronger opinion, but that's what we used to do.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 6, 2018

There is another way to be free from the deprecations: extract these from $argv right into bin/console.

@ogizanagi
Copy link
Contributor

Sure, why not. But we have to ensure it'll play well with #466. Unless we don't plan to finish & merge #466 soon, we might no need this one but directly see how to solve your comment within?

@chalasr
Copy link
Member

chalasr commented Nov 9, 2018

I think we can close, #481

@nicolas-grekas nicolas-grekas deleted the Tobion-patch-1 branch November 9, 2018 18:27
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this pull request Apr 16, 2023
…bion)

This PR was merged into the master branch.

Discussion
----------

Remove deprecated --env and --no-debug console options

See symfony/recipes#479

Commits
-------

6c49d74 Remove deprecated --env and --no-debug console options
spider-yamet added a commit to spider-yamet/sym_proj that referenced this pull request Apr 16, 2023
…bion)

This PR was merged into the master branch.

Discussion
----------

Remove deprecated --env and --no-debug console options

See symfony/recipes#479

Commits
-------

6c49d74 Remove deprecated --env and --no-debug console options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants