-
-
Notifications
You must be signed in to change notification settings - Fork 495
Remove deprecated "--env" and "--no-debug" console options #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Documentation wise https://symfony.com/doc/3.4/console/usage.html still mentions these options for symfony < 4. Maybe we should remove the page for 3.4 as well and add this part instead: https://symfony.com/doc/current/console.html#the-console-app-env-app-debug |
@Tobion It's similar to the new directory structure: the old translations/templates locations are still part of the 3.4 docs but the new ones are not, while they are actually supported since 3.4. |
#466 will contain these changes in a 4.2 recipe. I'd suggest either to wait for it to be (tweaked and) merged, or create the missing 4.2 recipe for console instead. |
…bion) This PR was merged into the master branch. Discussion ---------- Remove deprecated --env and --no-debug console options See symfony/recipes#479 Commits ------- 6c49d74 Remove deprecated --env and --no-debug console options
Should we really do this? In symfony/symfony#28984, people are complaining removing these attributes make the console harder to use for them. We did deprecate the options from core - and this was the thing to do to me also. BUT shouldn't we continue to allow using them here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just locking merges, I'd like my previous comment to be resolved first.)
That's for new projects or people manually upgrading to new versions of these recipes. A new project should be free of deprecations by default, that's my main argument here. No stronger opinion, but that's what we used to do. |
There is another way to be free from the deprecations: extract these from |
I think we can close, #481 |
…bion) This PR was merged into the master branch. Discussion ---------- Remove deprecated --env and --no-debug console options See symfony/recipes#479 Commits ------- 6c49d74 Remove deprecated --env and --no-debug console options
…bion) This PR was merged into the master branch. Discussion ---------- Remove deprecated --env and --no-debug console options See symfony/recipes#479 Commits ------- 6c49d74 Remove deprecated --env and --no-debug console options
Continuation of symfony/symfony#28653
Since the recipes are only used for new projects this seems safe to do. We do not want to promote using these options anymore.