Fix recipe: make consistent with symfony/flex 1.0 new env handling #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Nov 9, 2018
symfony/flex/1.0/.env.dist
Outdated
| @@ -0,0 +1,3 @@ | |||
| # This file is a "template" of which env vars need to be defined for your application | |||
| # Copy this file to .env file for development, create environment variables when deploying to production | |||
| # https://symfony.com/doc/current/best_practices/configuration.html#infrastructure-related-configuration No newline at end of file | |||
Member
Author
There was a problem hiding this comment.
Re-added until symfony/flex#434 is merged. Until then, if you don't have a .env.dist file, the "env" configurator won't work - i.e. it won't change your .env file when you install things.
nicolas-grekas
approved these changes
Nov 9, 2018
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
We'll need to remove .env.dist once flex is patched to not require it anymore. For now it's required.
Thanks!
Member
|
Flex PR is symfony/flex#434 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #481, the symfony/flex 1.0 recipe was changed so that the user gets a
.envfile and NOT a.env.dist. The gitignore recipe for FWBundle 4.2 was updated, but not 3.3.Cheers!