Exclude Tests from being scanned #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-bot
approved these changes
Jun 2, 2017
alOneh
approved these changes
Jun 2, 2017
javiereguiluz
previously approved these changes
Jun 2, 2017
xabbuh
approved these changes
Jun 2, 2017
nicolas-grekas
approved these changes
Jun 2, 2017
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Jun 3, 2017
This PR was merged into the 3.3 branch. Discussion ---------- exclude the Tests namespace see symfony/recipes#91 Commits ------- 8bcfad7 exclude the Tests namespace
VolCh
pushed a commit
to VolCh/recipes
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the best practice is to store tests under
tests/, some might still want to store them undersrc/Testsin which case, we want to exclude them for several reasons: first, no service should be defined there, so no need to scan the directory. But, more important, if PHPUnit is only install as a dev dependency, scanning on production will fail as the PHPUnit classes won't be available. This PR fixes this.