Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use extra.symfony.require to restrict versions of symfony/* #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Use extra.symfony.require to restrict versions of symfony/* #93

merged 1 commit into from
Aug 21, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Aug 14, 2018

Proposed way to leverage symfony/flex#409

Benefits:

  • no symfony/lts / symfony/force-lowest anymore
  • only one line to change to upgrade to next minor
  • better control of exact minor used (right now, skeleton:4.0 pulls 4.1 components)
  • faster dependency resolution thanks to flex pruning old tags
  • (and a lot less merge conflicts for us when merging 3.4 up to master);

@keradus
Copy link
Member

keradus commented Aug 14, 2018

will lts / force-lowest packages will be still maintained ?

@nicolas-grekas
Copy link
Member Author

I'd like we abandon them in favor of the new extra.symfony.require setting. It would simplify a lot the releasing process for us (maintaining the list of components in lts / force-lowest is extra work I'd like we could save us from doing.)

@keradus
Copy link
Member

keradus commented Aug 14, 2018

Would extra.symfony.require work without flex, then ?

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Aug 14, 2018

@keradus please check symfony/flex#409 (short answer: no ;) )

Copy link

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will simplify testing third party packages with different Symfony versions a lot, thanks!

@keradus
Copy link
Member

keradus commented Aug 14, 2018

So, that's was exactly my point. Using extra.symfony.require requires flex, so it would be nice to not abandon lts and force-lowest (even if skeleton would not use it anymore), for the ppl who are not using flex

@nicolas-grekas
Copy link
Member Author

The issue is that maintaining these packages is not free (it's a non trivial task that takes time). If one would like to maintain a fork, one will always be free to do it of course.

@keradus
Copy link
Member

keradus commented Aug 14, 2018

content of lts / force-lowest packages is super small and kind of trivial, while I agree that there is work to be done to maintain it. but especially with lts - not that much maintainance tbh...

we already have a bot that is bumping lock file, what about letting bot manage those packages as well ?

@fabpot
Copy link
Member

fabpot commented Aug 21, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 32dec7e into symfony:3.4 Aug 21, 2018
fabpot added a commit that referenced this pull request Aug 21, 2018
… (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Use extra.symfony.require to restrict versions of symfony/*

Proposed way to leverage symfony/flex#409

Benefits:
- no `symfony/lts` / `symfony/force-lowest` anymore
- only one line to change to upgrade to next minor
- better control of exact minor used (right now, skeleton:4.0 pulls 4.1 components)
- (and a lot less merge conflicts for us when merging 3.4 up to master);

Commits
-------

32dec7e Use extra.symfony.require to restrict versions of symfony/*
fabpot added a commit to symfony/website-skeleton that referenced this pull request Aug 21, 2018
… (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Use extra.symfony.require to restrict versions of symfony/*

Same as symfony/skeleton#93 on website-skeleton.
See symfony/flex#409

Commits
-------

b899463 Use extra.symfony.require to restrict versions of symfony/*
@nicolas-grekas nicolas-grekas deleted the symfony-require branch August 21, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants