-
-
Notifications
You must be signed in to change notification settings - Fork 127
Use extra.symfony.require to restrict versions of symfony/* #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
will |
I'd like we abandon them in favor of the new extra.symfony.require setting. It would simplify a lot the releasing process for us (maintaining the list of components in lts / force-lowest is extra work I'd like we could save us from doing.) |
Would |
@keradus please check symfony/flex#409 (short answer: no ;) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will simplify testing third party packages with different Symfony versions a lot, thanks!
So, that's was exactly my point. Using |
The issue is that maintaining these packages is not free (it's a non trivial task that takes time). If one would like to maintain a fork, one will always be free to do it of course. |
content of we already have a bot that is bumping lock file, what about letting bot manage those packages as well ? |
Thank you @nicolas-grekas. |
… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Use extra.symfony.require to restrict versions of symfony/* Proposed way to leverage symfony/flex#409 Benefits: - no `symfony/lts` / `symfony/force-lowest` anymore - only one line to change to upgrade to next minor - better control of exact minor used (right now, skeleton:4.0 pulls 4.1 components) - (and a lot less merge conflicts for us when merging 3.4 up to master); Commits ------- 32dec7e Use extra.symfony.require to restrict versions of symfony/*
… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- Use extra.symfony.require to restrict versions of symfony/* Same as symfony/skeleton#93 on website-skeleton. See symfony/flex#409 Commits ------- b899463 Use extra.symfony.require to restrict versions of symfony/*
Proposed way to leverage symfony/flex#409
Benefits:
symfony/lts
/symfony/force-lowest
anymore