minor #58499 [PhpUnitBridge] Use total for asserting deprecation count when a group is not defined (lyrixx)

nicolas-grekas · nicolas-grekas · commit 814397db9ea8 · 2024-10-21T11:56:21.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [PhpUnitBridge] Use `total` for asserting deprecation count when a group is not defined | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 02d1110 [PhpUnitBridge] Use 'total' for asserting deprecation count when a group is not defined
diff --git a/src/Symfony/Bridge/PhpUnit/CHANGELOG.md b/src/Symfony/Bridge/PhpUnit/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add `ExpectUserDeprecationMessageTrait` with a polyfill of PHPUnit's `expectUserDeprecationMessage()`
+ * Use `total` for asserting deprecation count when a group is not defined
 
 6.4
 ---
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
@@ -96,7 +96,7 @@ private function __construct(array $thresholds = [], string $regex = '', array $
         }
         foreach ($groups as $group) {
             if (!isset($this->thresholds[$group])) {
-                $this->thresholds[$group] = 999999;
+                $this->thresholds[$group] = $this->thresholds['total'] ?? 999999;
             }
         }
         $this->regex = $regex;

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ private function __construct(array $thresholds = [], string $regex = '', array $`
`96`	`96`	`}`
`97`	`97`	`foreach ($groups as $group) {`
`98`	`98`	`if (!isset($this->thresholds[$group])) {`
`99`		`- $this->thresholds[$group] = 999999;`
	`99`	`+ $this->thresholds[$group] = $this->thresholds['total'] ?? 999999;`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`	`$this->regex = $regex;`