Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create a script to automate the submission of a patch #11660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexislefebvre opened this issue Aug 12, 2014 · 6 comments
Closed

Create a script to automate the submission of a patch #11660

alexislefebvre opened this issue Aug 12, 2014 · 6 comments
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony)

Comments

@alexislefebvre
Copy link
Contributor

The process to submit a patch involves many steps which require to type or copy-paste commands in a terminal, and they must be repeated for every patch.

I suggest to create a script (for example in bash) to handle the submission of a patch. This script could be hosted in the repository in order to be accessible by all the contributors. It should check every step to ensure that a patch is valid before submitting it. I don't know git enough to create an example of this script so I'm just suggesting the idea.

This script may:

  • display informative text during all the process
  • check that all unit tests pass
  • choose the right branch
  • automate the creation of a topic branch
  • display recommendations about writing good commit messages
  • etc.
@stof stof added the DX label Aug 18, 2014
@cordoval
Copy link
Contributor

this could perhaps be accomplished on SE? sounds like a command with question helper calls. The sensio distro bundle or others host some of the SymfonyRequirements as well that seem similar to what you are describing. So these scripts exist in some bundles. I would recommend Gush but not everybody is happy about gush. And not sure how to plug gush without having you download the phar and configure. So it sounds more of a command thing, though the phpunit tests would perhaps take sometime. There is jolici which can run the tests in docker but it has very strict requirements and more complications.

@lmammino
Copy link

👍 for gush! Great tool out there

@mtotheikle
Copy link

What are people not happy about with Gush @cordoval ?

@cordoval
Copy link
Contributor

cordoval commented Sep 5, 2014

is not gh the internal tool maintainers use i guess, not sure

@wouterj
Copy link
Member

wouterj commented Sep 8, 2014

-1

This is all just the Git process, it's not specific to Symfony. A tool designed for this can be used for any other OSS project. This means that such a tool is outside the range of the Symfony project and should be handled by other projects. Gush is an example of this, but there are also others around such as Hub.

@fabpot
Copy link
Member

fabpot commented Dec 24, 2014

As mentioned by @wouterj, we don't want to deviate from any other Git projects.

@fabpot fabpot closed this as completed Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony)
Projects
None yet
Development

No branches or pull requests

7 participants