-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Create a script to automate the submission of a patch #11660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this could perhaps be accomplished on SE? sounds like a command with question helper calls. The sensio distro bundle or others host some of the SymfonyRequirements as well that seem similar to what you are describing. So these scripts exist in some bundles. I would recommend Gush but not everybody is happy about gush. And not sure how to plug gush without having you download the phar and configure. So it sounds more of a command thing, though the phpunit tests would perhaps take sometime. There is jolici which can run the tests in docker but it has very strict requirements and more complications. |
👍 for gush! Great tool out there |
What are people not happy about with Gush @cordoval ? |
is not gh the internal tool maintainers use i guess, not sure |
-1 This is all just the Git process, it's not specific to Symfony. A tool designed for this can be used for any other OSS project. This means that such a tool is outside the range of the Symfony project and should be handled by other projects. Gush is an example of this, but there are also others around such as Hub. |
As mentioned by @wouterj, we don't want to deviate from any other Git projects. |
The process to submit a patch involves many steps which require to type or copy-paste commands in a terminal, and they must be repeated for every patch.
I suggest to create a script (for example in bash) to handle the submission of a patch. This script could be hosted in the repository in order to be accessible by all the contributors. It should check every step to ensure that a patch is valid before submitting it. I don't know git enough to create an example of this script so I'm just suggesting the idea.
This script may:
The text was updated successfully, but these errors were encountered: