Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.2][Form] Empty strings instead of null in CountryType #20759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geoffrey-brier opened this issue Dec 5, 2016 · 4 comments
Closed

[3.2][Form] Empty strings instead of null in CountryType #20759

geoffrey-brier opened this issue Dec 5, 2016 · 4 comments
Labels
Bug Form Status: Reviewed

Comments

@geoffrey-brier
Copy link
Contributor

geoffrey-brier commented Dec 5, 2016 •
edited
Loading

After upgrading in 3.2, when I submit a form which contains some CountryType elements and I don't submit those ones, then the value saved is an empty string while in 3.1 and below it was null.

According to the documentation of the CountryType, it's the intended behaviour but my tests are telling me that something changed.
@geoffrey-brier geoffrey-brier changed the title [3.2][Form] Empty strings instead of null in ChoiceType [3.2][Form] Empty strings instead of null in CountryType Dec 5, 2016
@HeahDude
Copy link
Contributor

HeahDude commented Dec 5, 2016

Hey @geoffrey-brier, have some time to add the minimum of code in a fork of symfony standard to reproduce this? I'll have a look when I can, thanks!

@xabbuh
Copy link
Member

xabbuh commented Jan 6, 2017 •
edited
Loading

Closing due to the lack of feedback.

@geoffrey-brier Please comment if you can provide additional information and we can consider to reopen.

@xabbuh xabbuh closed this as completed Jan 6, 2017
@geoffrey-brier geoffrey-brier mentioned this issue Jan 31, 2017
Closed
@geoffrey-brier
Copy link
Contributor Author

@HeahDude @xabbuh Just created the test cases

@xabbuh xabbuh reopened this Jan 31, 2017
@HeahDude HeahDude mentioned this issue Jan 31, 2017
Merged
@HeahDude
Copy link
Contributor

HeahDude commented Feb 1, 2017

Will be closed by #21481.

Status: reviewed

fabpot added a commit that referenced this issue Mar 5, 2017
@fabpot
bug #21481 [Form] Fixed empty conversion of Intl types (HeahDude)
16263fb 
This PR was merged into the 3.2 branch.

Discussion
----------

[Form] Fixed empty conversion of Intl types

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20759, #21475
| License       | MIT
| Doc PR        | ~

Commits
-------

e43bfaf [Form] Fixed empty conversion of Intl types
@fabpot fabpot closed this as completed Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @geoffrey-brier @xabbuh @HeahDude @carsonbot