[Form] Reproduce CountryType BC break #21475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @geoffrey-brier I've continued in #21481. |
|
closing in favour of #21481 |
fabpot
added a commit
that referenced
this pull request
Mar 5, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [Form] Fixed empty conversion of Intl types | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20759, #21475 | License | MIT | Doc PR | ~ Commits ------- e43bfaf [Form] Fixed empty conversion of Intl types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've created test cases to reproduce #20759 . I've realized that not only the
CountryTypeis affected by this problem but also theMoneyType,LanguageType,LocaleType... in other words all types havingChoiceTypeas their parent. What's also interesting to point out is that most of those types are implementing theChoiceLoaderInterfacesince version 3.2To be honest, I'm a bit lost about where to look but I'm sure the test cases are going to prove useful.