-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel][Console] Inconsistent logging between the components #39050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
See also #29138 |
I'm closing this issue for the reasons given in #29138. |
Reasons given in #29138 do not address the issue at all.
Why would
Unexpected exceptions should logged at |
jderusse
added a commit
that referenced
this issue
Jan 28, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Fix console logger according to PSR-3 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #39050, #29138 | License | MIT `Symfony\Component\HttpKernel\EventListener\ErrorListener` logs non-HTTP exceptions at `LogLevel::CRITICAL`. `Symfony\Component\Messenger\Worker` logs unrecoverable exceptions at `LogLevel::CRITICAL`. `Symfony\Component\Console\EventListener\ErrorListener` logs exceptions at `LogLevel::ERROR`. As per PSR-3, unexpected and unrecoverable exceptions should be logged at `LogLevel::CRITICAL`. Commits ------- 69fcd07 Fix console logger according to PSR-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected: 3.4, 4.4, 5.x
Description
Symfony\Component\HttpKernel\EventListener\ErrorListener
logs non-HTTP exceptions asLogLevel::CRITICAL
.Symfony\Component\Console\EventListener\ErrorListener
logs exceptions asLogLevel::ERROR
.This is incoherent. Both listeners should log non-HTTP exceptions at the same level.
Possible Solution
Correcting
Symfony\Component\Console\EventListener\ErrorListener
so it logs atLogLevel::CRITICAL.
The text was updated successfully, but these errors were encountered: