Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Fix console logger according to PSR-3 #39920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alex-dev
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #39050, #29138
License MIT

Symfony\Component\HttpKernel\EventListener\ErrorListener logs non-HTTP exceptions at LogLevel::CRITICAL.
Symfony\Component\Messenger\Worker logs unrecoverable exceptions at LogLevel::CRITICAL.
Symfony\Component\Console\EventListener\ErrorListener logs exceptions at LogLevel::ERROR.

As per PSR-3, unexpected and unrecoverable exceptions should be logged at LogLevel::CRITICAL.

@alex-dev alex-dev requested a review from chalasr as a code owner January 21, 2021 14:10
@carsonbot carsonbot added this to the 4.4 milestone Jan 21, 2021
@carsonbot carsonbot changed the title Fix console logger according to PSR-3 [Console] Fix console logger according to PSR-3 Jan 21, 2021
@YaFou
Copy link
Contributor

YaFou commented Jan 21, 2021

Related to #29138

@jderusse
Copy link
Member

Thank you @alex-dev.

@jderusse jderusse merged commit 945c7c5 into symfony:4.4 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants