Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2.2] Wrong option name in FragmentHandler::fixOptions #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iamdto opened this issue Mar 8, 2013 · 3 comments
Closed

[2.2] Wrong option name in FragmentHandler::fixOptions #7309

iamdto opened this issue Mar 8, 2013 · 3 comments

Comments

@iamdto
Copy link

iamdto commented Mar 8, 2013

Shouldn't the new name be strategy instead of renderer for the deprecated standalone option in FragmentHandler::fixOptions ?

The documentation doesn't say anything about this, but HttpKernelExtension::renderFragment seems to use the name strategy.

I can fix this if needed.
@fabpot
Copy link
Member

fabpot commented Mar 8, 2013

Looks like a bug indeed.

@aitboudad aitboudad mentioned this issue Mar 10, 2013
Closed
@aitboudad
Copy link
Contributor

#7321 fixed

@iamdto
Copy link
Author

iamdto commented Mar 10, 2013

👍

@fabpot fabpot closed this as completed Mar 11, 2013
ondrejmirtes pushed a commit to ondrejmirtes/symfony that referenced this issue Nov 25, 2013
@fabpot
merged branch Aitboudad/ticket_7309 (PR symfony#7321)
6c1e86c 
This PR was squashed before being merged into the 2.2 branch (closes symfony#7321).

Commits
-------

4f3771d [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions

Discussion
----------

[2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#7309

---------------------------------------------------------------------------

by Aitboudad at 2013-03-10T11:38:59Z

Hi @fabpot,
can you see why  all commits has failed on Travis ?

---------------------------------------------------------------------------

by henrikbjorn at 2013-03-10T11:42:25Z

The test expects the option to be called `renderer` and not `strategy` so you need to change the tests.

---------------------------------------------------------------------------

by Aitboudad at 2013-03-10T12:19:19Z

@henrikbjorn thanks it's ok, but there is still 1 test :( in Symfony\Component\Form\Tests\Extension\Core\Type\TimeTypeTest::testSetDataDifferentTimezones
@bschussek Can you see why :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @iamdto @aitboudad