[HttpKernel] Revert BC break introduced by #8957 #11039
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopened against the good branch: #11040 |
|
maybe the create method needs to be rather modified to accept a class that was extended from? maybe it is not a good idea, but Doctrine entity repository factories do this? |
|
@cordoval it cannot (BC break). But there is already an extension point in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
464439d (#8957) creates a BC break. At least the SonataPage CMS used with the "host and path" strategy (http://sonata-project.org/bundles/page/master/doc/reference/multisite.html#host-and-path-strategy) is not working anymore because of this patch.
SonataPage extends the
Requestclass without using the new factory system (there is probably a cleaner way to implement the "host and path" strategy in the CMS too).When a subrequest is handled by
InlineFragment, a request of typeSymfony\Component\HttpFoundation\Requestis instantiated instead of the expectedSonata\PageBundle\Request\SiteRequest. Then, SonataPage fail on the subrequest.I've just reverted the part of this commit changing the previous behavior, the factory system is still working.
ping @fabpot @rande @Sinjonathan