[HttpKernel] Revert BC break introduced by #8957 #11040
Conversation
|
the Sonata bundle should be updated to use the supported extension point instead IMO |
|
@stof I agree, the SonataBundle must be fixed. But this BC break should be fixed too. This patch is tiny and using a static method on an instance instead of a class is not a problem (this is documented as allowed: http://php.net/manual/en/language.oop5.static.php). |
|
btw, if the Sonata bundle is broken since more than 6 months (this change was released with 2.4.0 6 months ago) without anyone noticing it, the question is whether the feature is used much. |
|
We were using it on some projects with a 2.3 (LTS, not affected by this bug) and are considering an upgrade to 2.5. It's how we found this problem. |
|
@stof is right, if it was released with 2.4.0 that means added functionality so this is valid. We should however include the fix on 2.4.* so that this gets supported as a bugfix and makes it BC with this use case. |
|
Extending the Request class is a very bad practice. Supporting it is an edge case and I added support for it quite reluctantly. This kind of PRs/issues make me think that it was indeed a bad idea to support that. So, as nobody had this problem during the last 6 months, it confirms that this is indeed an edge case; so closing this as the change occurred in a new version (not in a bug fix one). |
|
Oh this made me think of a tool I have been thinking about writing to analyze BC. I just started it tonight https://github.com/cordoval/bc-analyzer |
464439d (#8957) creates a BC break. At least the SonataPage CMS used with the "host and path" strategy (http://sonata-project.org/bundles/page/master/doc/reference/multisite.html#host-and-path-strategy) is not working anymore because of this patch.
SonataPage extends the
Requestclass without using the new factory system (there is probably a cleaner way to implement the "host and path" strategy in the CMS too).When a subrequest is handled by
InlineFragment, a request of typeSymfony\Component\HttpFoundation\Requestis instantiated instead of the expectedSonata\PageBundle\Request\SiteRequest. Then, SonataPage fail processing the subrequest.I've just reverted the part of this commit changing the previous behavior, the factory system is still working.
ping @fabpot @rande @Sinjonathan